Skip to content

fix(rbac): alert display issue after role creating/updating #1354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2024
Merged

fix(rbac): alert display issue after role creating/updating #1354

merged 1 commit into from
Mar 26, 2024

Conversation

ciiay
Copy link
Contributor

@ciiay ciiay commented Mar 19, 2024 •
edited
Loading

For RHIDP-1362
e2e test updated: redhat-developer/rhdh#1090

screen recording;

alert_display_fix.mov

@ciiay ciiay requested a review from a team as a code owner March 19, 2024 22:12
@openshift-ci openshift-ci bot requested review from debsmita1 and nickboldt March 19, 2024 22:12
@ciiay ciiay mentioned this pull request Mar 19, 2024
Merged
5 tasks
@debsmita1
Copy link
Member

This works fine on showcase now

Screen.Recording.2024-03-21.at.3.38.00.PM.mov

Could you please update the rbac-backend version in the backend/package.json to the latest version ? Also, please squash the commits.

Thank you for fixing this issue :)

@ciiay ciiay force-pushed the rhidp-1362-fix-alert-display-issue branch from 0b173dc to 31ab9b3 Compare March 21, 2024 14:05
@ciiay ciiay requested a review from a team as a code owner March 21, 2024 14:05
@ciiay ciiay force-pushed the rhidp-1362-fix-alert-display-issue branch from 89faa50 to a3954e0 Compare March 21, 2024 14:16
@ciiay ciiay force-pushed the rhidp-1362-fix-alert-display-issue branch 4 times, most recently from ad0b1b0 to 6a02c27 Compare March 21, 2024 15:30
@invincibleJai
Copy link
Member

/approve

/cc @debsmita1

invincibleJai
invincibleJai reviewed Mar 22, 2024
View reviewed changes
@ciiay ciiay requested a review from invincibleJai March 22, 2024 14:40
@ciiay ciiay force-pushed the rhidp-1362-fix-alert-display-issue branch from 4509e7d to 99d058f Compare March 22, 2024 14:49
@invincibleJai
Copy link
Member

Jobs are failing with below

$ prettier --ignore-unknown --check .
Checking formatting...
[warn] .github/dependabot.yml
[warn] Code style issues found in the above file. Run Prettier to fix.
error Command failed with exit code 1.

this has been fixed now but rerun didn't helped, try rebase and push

@ciiay ciiay force-pushed the rhidp-1362-fix-alert-display-issue branch from 49e1bd8 to 8261b2e Compare March 26, 2024 12:10
@ciiay ciiay force-pushed the rhidp-1362-fix-alert-display-issue branch from 8261b2e to 433a3be Compare March 26, 2024 12:17
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.8% Duplication on New Code

See analysis details on SonarCloud

@debsmita1
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 26, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: debsmita1, invincibleJai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [debsmita1,invincibleJai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 2e04ccb into janus-idp:main Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@debsmita1 debsmita1 Awaiting requested review from debsmita1

@nickboldt nickboldt Awaiting requested review from nickboldt

@AndrienkoAleksandr AndrienkoAleksandr Awaiting requested review from AndrienkoAleksandr

@PatAKnight PatAKnight Awaiting requested review from PatAKnight

@invincibleJai invincibleJai Awaiting requested review from invincibleJai

Assignees

@debsmita1 debsmita1

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ciiay @debsmita1 @invincibleJai